PhonologicalCorpusTools / SLPAA

5 stars 0 forks source link

"Upper leg" and buried nodes locations repeated + not saving #265

Closed maggieer closed 7 months ago

maggieer commented 7 months ago

Describe the bug In the location module, the Leg and foot>Upper leg node and its buried nodes (Upper leg - ipsi and Upper leg - contra) are repeated twice in the list of tree nodes. In addition, none of the "Upper leg" nodes stay populated upon saving and re-opening the module.

Sample corpus file https://drive.google.com/file/d/1WYJ3BOpGIB-ij9Q0cXqdIwDt3Y-8vofu/view?usp=drive_link See the empty tree nodes in H1_Loc1 and H2_Loc1 for entry PANTS (v. 1) and in H1_Loc2, H1_Loc4, H2_Loc2 and H2_Loc4 for entry PANTS (v. 2)

To Reproduce Steps to reproduce the behavior:

  1. Open SLPAA
  2. Open any corpus/load a new corpus
  3. Enter location module
  4. Enter drop-down tree node menu
  5. Scroll down to Leg and foot>Upper leg selections
  6. See repetition error
  7. Select any "Upper leg" selection
  8. Save and close
  9. Re-open same location module
  10. See empty tree node error

Expected behavior I expected to see only one listing of "Upper leg" and only one listing of each of its two buried nodes. I also expected for the tree node to remain populated upon saving.

Error messages None from the Powershell window.

Screenshots GitHub_issue 2024_01_10_PACK_PANTS_v2_MR_new_main_SCREENSHOT

Operating system and SLP-AA version

gracemyz commented 7 months ago

@maggieer I've removed the repeated Upper leg node. Selections should save correctly now, but any upper leg nodes that were missing before this update will need to be re-added - sorry about that!