search

PhonologicalCorpusTools / SLPAA

5 stars 0 forks source link

audit persistence of saved data #270

Open kvesik opened 7 months ago

kvesik commented 7 months ago

Kathleen mentions in this comment in PR #268 :

I'm a bit worried that there might still be some missing information. E.g. in the corpus 2023_03_14_ABBREVIATE_ACCIDENT_v3_AA_KCH_YG_KCH.slpaa from "checked files + checked contact," the sign ACCEPT has a Relation module. If I look at this module in the "frozen" October branch, I can see that there are specified handparts (specifically, fingers / tips for H1). But if I look at this in the 234 branch, this information is missing, and no warning is thrown.

(More generally: I'm a bit worried about the saving features in the software. As I went through and checked several corpora for this review, elements that I had worked on previously and thought I saved seemed to be missing, even when other changes to the same corpus were present. We need to do some kind of proper audit. The above example is just one that is actually observably different between the frozen branch and the 234 branch.)

kvesik commented 7 months ago

@kchall when you have a moment would you mind listing a few examples of corpora/signs/branches where you've noticed things... disappearing? I'm happy to comb through some arbitrary data, but it'd be nice to have a place to start if you've got any examples at hand.

kvesik commented 7 months ago

Check "notes from Kathleen" column in the "Signs to Code" spreadsheet for possible contact-related issues.