search

PhonologicalCorpusTools / SLPAA

5 stars 0 forks source link

[BUG] "filter by gloss" currently searches entry id column, not gloss column #303

Closed kvesik closed 2 months ago

kvesik commented 3 months ago

Since EntryID took the place of Gloss as column 0 in the corpus display, "filter by gloss" no longer actually does what it says. [must be in branch 105 or have merged that branch into main...]

Matches Entry ID string: image

But not gloss string: image

Ensure that "filter by gloss" searches column 1, not column 0, of the corpus table.

kvesik commented 3 months ago

working on this in branch 105 (as part of #105), since it doesn't (yet) appear in main

kvesik commented 3 months ago

@kchall in branch 105, which has the 4-column corpus table display, would you like the "filter by gloss" text box to filter only by gloss, or would you like to adjust the feature so that it can match text in any of the 4 columns (entry id, gloss, lemma, idgloss)? Both are one-line implementations, so whichever you prefer I'm happy to do!

kchall commented 3 months ago

@kvesik Awesome, if it's easy to do any of them, then let's do that! Thanks!