PhonologicalCorpusTools / SLPAA

5 stars 0 forks source link

Add final few location images and interactions #337

Open kvesik opened 5 months ago

kvesik commented 5 months ago

Location module images

When issue #85 was closed, there were a couple of placeholders/workarounds we were using that need to eventually be implemented properly. These are the outstanding items:

Mouth interior

For regions inside the mouth (tongue, upper teeth, lower teeth) highlighted by default in yellow, we are temporarily using the violet "Mouth" image as a placeholder. There are empty .txt files in the yellow subfolder of predefined_locations that flag their corresponding .svg files as placeholders.

Selected fingers

For regions involving selected fingers (selected fingers, selected fingers and thumb) highlighted by default in yellow, we are temporarily using the violet "Whole hand" image as a placeholder. There are empty .txt files in the yellow subfolder of predefined_locations that flag their corresponding .svg files as placeholders.

Side view

This one is a slightly different kind of issue. We do have a side view full-body drawing for use in the Location module, but as far as I can see there were never any versions of it created that show actual location regions highlighted on the body. So for now, I've removed the Side view tab from the Location module since it wasn't providing any useful information anyway. However, it would make sense to eventually:

See original mention of the first two topics here: Originally posted by @kvesik in https://github.com/PhonologicalCorpusTools/SLPAA/issues/85#issuecomment-1989650511