PhonologicalCorpusTools / SLPAA

5 stars 0 forks source link

85: location module visual interface #353

Closed kvesik closed 3 months ago

kvesik commented 3 months ago

Permits viewing and selection of location regions in the Location Dialog via visual interface, in addition to text search in combobox.

kchall commented 3 months ago

@kvesik This all looks great to me and seems to be working as expected. The only tweak I might suggest is that currently (by design), the image isn't available for clicking on when a user first creates an instance of the module, because it's only available when a 'body' location is selected. But that might not be entirely intuitive; would it be possible to have the image be clickable on launch, and if it is clicked, the system defaults to 'body' location (even though yes, I know it could also be body-anchored)? and then it is only not-clickable if the user has actively selected 'purely spatial'?

@kvesik Hmm, actually, I was reminded by Grace's work on the default neutral button that we do also have an option in the main "Preferences / Location" tab for which location is selected by default, so my above solution might be complicated by that. Perhaps better to just modify the tooltip to explicitly say 'Visual interface available if a body location is specified. ...' (before the current specification of keyboard shortcuts).

kvesik commented 3 months ago

@kchall I implemented a variation on your request above:

kchall commented 3 months ago

@kvesik Oh, that's brilliant -- even better, thank you!