PhonologicalCorpusTools / SLPAA

5 stars 0 forks source link

338 make hand configuration dialog less horizontal #358

Closed stannam closed 1 month ago

stannam commented 1 month ago

This PR modifies the way the hand configuration specification dialog is shown.

Previously, the window was so wide that it went beyond the screen horizontally on MacOS. This PR presents widgets on many levels, making use of more vertical space. It also enlarges the predefined handshape image.

Main This PR
Screenshot 2024-07-24 at 7 25 49 PM Screenshot 2024-07-24 at 7 27 18 PM

@kchall and @kvesik , can you make sure the dialog shows up as intended, especially on MacOS?

kvesik commented 1 month ago

@stannam looks good on my Windows machine. @kchall do you think that it would make more sense to adjust the layout such that the forearm box was also R-aligned, along with the two rows of fields/slots?

kchall commented 1 month ago

@stannam , @kvesik This looks great to me! I can see arguments both ways for the left- vs. right-justification of the 'forearm' field, so let's just leave it as is for the sake of time. Thank you! :)

Harukaichii commented 1 month ago

For the record, here's what it looks like on my Mac:

スクリーンショット 2024-07-31 午後10 05 39

I do believe I'm probably a minority since my screen size is small but this is much better to slide the window around :D. Thanks!!

However I'm still struggling with using the location module because I can't get to the save button at all:

スクリーンショット 2024-07-31 午後10 06 57

hence can someone make a follow up ticket to just make the boxes scrollable ? 😅 or a stretch goal to do some more calculation for window size (idk if there's a library that does this already) and resize everything accordingly?

kvesik commented 1 month ago

@Harukaichii thanks for the reminder! #366 is a new ticket for this problem.