Phorum / Core

The core of Phorum
http://www.phorum.org
68 stars 34 forks source link

Search bots generating modscript errors on addon.php #1000

Closed oricgn closed 7 years ago

oricgn commented 7 years ago

It is part of the nature of search bots to visit each know webpage (also) without any query string even if all original links have a query string.

addon.php triggers each time an error if "module" is missing.

I think it shouldn't be treated as an error if the script is called without a query string. Only an incomplete query string should trigger an error message.

Perhaps it's a good idea to redirect search bots to index.php.

cactux commented 7 years ago

Perhaps it's a good idea to redirect search bots to index.php. This should be done very carefully, as it can have a bad impact on SEO. If a page as a different behavior for a bot than for a regular user, then it is flagged as suspicious by the bot. If you meant "addon.php should redirect to index.php when there's no module", then ok, but for all users, not only bots (even if only bots should send such request).

oricgn commented 7 years ago

Yes, you are right, I mean "addon.php should redirect to index.php when there's no query string".

oricgn commented 7 years ago

Same to css.php.

oricgn commented 7 years ago

Fixed in master and branch_5_2