[REVERTED] add dynamic fork settings

Phoscur / QMK-compile

Github Action to compile QMK firmware

MIT License

0 stars 3 forks source link

[REVERTED] add dynamic fork settings #1

Closed 5andr0 closed 1 year ago

5andr0 commented 1 year ago

notes:

the basic docker action has no build arg support so i had to run the docker cmds manually
when you don't set a branch with the qmk setup cmd it defaults to master, which won't work with zsa/qmk_firmware that's why I'm cloning forks manually with git, because it always clones the latest default branch. that way you don't have to hardcode the firmware version, which was already outdated

Phoscur commented 1 year ago

@5andr0 sorry decided to revert the main branch after some hours of trying to fix it. I planned other things for today, I'd rather have you try this a second time, and please properly test this time!

5andr0 commented 1 year ago

@5andr0 sorry decided to revert the main branch after some hours of trying to fix it. I planned other things for today, I'd rather have you try this a second time, and please properly test this time!

I am soo sorry! I thought I tested all possible config settings, but I just figured out that my push to change the ergodox-macro-hax workflow to use my fork didn't go through. So i've been testing against your repo all the time and my local tests didn't include the compose file. Sorry for the trouble! Will do proper testing later and fix everything. Have a nice weekend

Phoscur commented 1 year ago

Thank you, I will keep supporting you with #2, sadly it was not just a few simple bugs, check the develop branch! @5andr0

Here is another idea that came up: Do we want oryx download as a separate/sibling or derived GA?