search

Photometrics / PyVCAM

Python3.X wrapper for Photometrics and QImaging PVCAM based cameras
MIT License
36 stars 17 forks source link

Allow linux installation with default location #22

Closed bagel897 closed 2 years ago

bagel897 commented 3 years ago

Changes:

  1. allow direct installation via git for tools like poetry by reorganizing repository
  2. For linux, if environment variable isn't set use the default pyvcam sdk installation
  3. Add dependencies to setup.py
stevebellinger commented 3 years ago

Hello bageljrkhanofemus.

Sorry about the lateness of this reply, but I needed time to consider these changes.

  1. Approved.
  2. I'm not sure this change is needed. The environment variable will be set during PVCAM installation which is a requirement for building and running pyvcam. Please comment if there are other reasons for this change.
  3. I think install_requires change is nice addition, but I don't believe pyserial and libtiff are needed. The comment at the end of setup.py needs to be cleaned up.

If you are still interested, I can commit this branch after the items above are resolved. We are also preparing another formal release of PyVCAM. Regardless of your actions, portions of this pull-request will be incorporated into our internal version of PyVCAM which will be posted to github pending validation in approximately one month.

Thank you for your contributions.

bagel897 commented 2 years ago

Hello Steve. Sorry for the late response, I'm no longer working at the research lab I did this work for. Therefore, I can no longer test anything. I think the environment variable wasn't set properly in the Linux install, but is easy enough to handle. Since the more important directory structure change has been handled, this pull request is no longer necessary. Thank you