AAC hook not working properly

[iFlamingoz]

6.5.3: 7.1.2:

Server Information: Server Ver: PaperSpigot 1.8.8 AACAdditionPro Ver: 7.1.4 AAC Ver: 5.1.0 Protocollib Ver: 4.7.0

[iFlamingoz]

Seems like this might be the case for commands on modules as well. Without AAC: https://prnt.sc/1fm2u0a With: https://prnt.sc/1fm5crv

[Photon-GitHub]

Yes, that is intended behaviour, just read the config comments:

# If this option is active and AAC is installed AACAdditionPro will not execute any commands specified above and instead
# hooks the AAC feature system to allow you to specify punishments via the AAC config.
# This way, AACAdditionPro's checks will also appear in AAC's status messages.

I mean, I could add an option to still execute the commands, but that would kind of defeat the purpose of AAC integration…

[iFlamingoz]

Alright thought sentinel commands should execute even if AAC was hooked

[Photon-GitHub]

You can access the sentinel modules just like any other in the AAC config and punish there.

[iFlamingoz]

Thresholds don't seem to be executing even when in the AAC config? (tested using default Celebrimbour's optimized configs)

[AACAdditionPro] IFlamingoz [AACAdditionPro] Inventory -> vl 591 [AACAdditionPro] Inventory.parts.Move -> vl 579 [AACAdditionPro] Scaffold -> vl 483

[Janmm14]

I think theres a maximum vl AAC 5 allows per check which also applies to plugins using AAC's api.

[iFlamingoz]

Those checks are supposed to execute at 120 vl.

[iFlamingoz]

Versions 6.5.3 and below do not seem to have this issue. The only check that seems to run thresholds is the Pingspoof check.

[Photon-GitHub]

Indeed, version 7 unified the module system. Before, Sentinel was not hooked into AAC and used a different system compared to the regular checks. This was one of the motivators of version 7, in which modules are much easier to add.

[iFlamingoz]

Indeed, version 7 unified the module system. Before, Sentinel was not hooked into AAC and used a different system compared to the regular checks. This was one of the motivators of version 7, in which modules are much easier to add.

Yes, however, aren't checks like Inventory move supposed to run thresholds from the AAC config and be displayed in a players AAC status message?

6.5.3:

7.1.2:

[Photon-GitHub]

That is indeed a bug if you enabled the hook in the config.

[iFlamingoz]

That is indeed a bug if you enabled the hook in the config.

Yes, the hook is enabled and the only check (out of the ones I have tested) that seem to run thresholds and show up in peoples AAC status messages is the PingSpoof check.

[Photon-GitHub]

@iFlamingoz could you please pm me your AAC and AACAdditionPro configs? (On Discord / Spigot)

[iFlamingoz]

@iFlamingoz could you please pm me your AAC and AACAdditionPro configs? (On Discord / Spigot)

Done (on discord)

[Photon-GitHub]

AAC Hook has been removed in 8.0.0 as AAC is no longer maintained.