search

Photon-GitHub / AntiCheatAddition

An anticheat with nieche checks to cover cheats usually not covered by anticheats.
GNU General Public License v3.0
155 stars 42 forks source link

Performed refactoring #549

Closed MaulikGajipara007 closed 1 year ago

MaulikGajipara007 commented 1 year ago

Applied some refactoring techniques for improving the code quality.

Janmm14 commented 1 year ago

No improved code quality. Removed record usage without telling anyone why. Weird renaming of Esp.INSTANCE Code quality doesn't improve by changing lambda to its own function handleLogs. Why move handler list to abstract superclass? This should actually lower performance of events. Why have two functions for comparing chunk x and chunk z just differently named when the variable names itself are already verbose enough.

I do not see any improvement in how you changed supported click types, I think the new code is worse.

Please provide more context for your changes. Why you did them, what exactly does improve 1.8 compatibility and why.

Photon-GitHub commented 1 year ago

Nonetheless, I want to genuinely thank you for the effort of actually trying to refactor my plugin. It is a great way of starting to understand larger projects. If you want to try a plugin which has a lot more opportunity for refactoring, you could try out ProtocolLib 😄