search

Photon-GitHub / AntiCheatAddition

An anticheat with nieche checks to cover cheats usually not covered by anticheats.
GNU General Public License v3.0
152 stars 45 forks source link

Refactor the implementation and design smell #581

Closed MevawalaBhavya closed 6 months ago

Janmm14 commented 8 months ago

There is no need to remove existing javadoc from methods.

Photon-GitHub commented 8 months ago

Hey, thank you for opening a pull request.

I am sorry to ask, but does this even compile?

There are a lot of classes that access Data and TImeMap. By extracting them to another UserData class the access chains will be longer and you need to modify all of them, but I only see changes in 7 files. I also don't think that change will make the code any more readable for that exact reason.

Also, as Janmm14 already mentioned, why did you delete all the documentation?