Photon-GitHub / AntiCheatAddition

An anticheat with nieche checks to cover cheats usually not covered by anticheats.
GNU General Public License v3.0
152 stars 45 forks source link

ChestStealer bypass #605

Closed Regomy closed 1 month ago

Regomy commented 2 months ago

ChestStealer code:


public class ChestStealer extends Module {
ModeSetting mode = new ModeSetting("Mode", "Normal", "Instant", "Normal");
public ChestStealer() {
super("ChestStealer", Category.PLAYER);
addSettings(mode);
}
@Override
public void onEvent(Event event) {
    if(!(event instanceof EventUpdate) || !(mc.currentScreen instanceof GuiChest)) {
        return;
    }

    ContainerChest chest = (ContainerChest) mc.thePlayer.openContainer;

    for(byte slot = 0; slot < chest.getLowerChestInventory().getSizeInventory(); slot++) {
        if(chest.getLowerChestInventory().getStackInSlot(slot) == null) {
            continue;
        }

        mc.playerController.windowClick(chest.windowId, slot, 0, 1, mc.thePlayer);

        if(mode.isCurrent("Normal")) {
            break;
        }
    }
}

}



> **video:** https://youtu.be/_Io_AiTaQT0
> **logs:** [2024-05-13.log](https://github.com/Photon-GitHub/AntiCheatAddition/files/15296739/2024-05-13.log)
Photon-GitHub commented 2 months ago

Are you absolutely sure that you do not have bypass permissions or OP? At least 3 different checks should pick that up, not to mention that someone tested this for the 9.0.0 release. If possible, test with an another account to make sure that some permissions do not interfere.

The log only shows the batch processors, which might be a bug as they do not fully bypass players with bypass permissions right now.

Regomy commented 2 months ago

Are you absolutely sure that you do not have bypass permissions or OP? At least 3 different checks should pick that up, not to mention that someone tested this for the 9.0.0 release. If possible, test with an another account to make sure that some permissions do not interfere.

The log only shows the batch processors, which might be a bug as they do not fully bypass players with bypass permissions right now.

And yes... and no... :D

🥇 Most likely the point is that all of these items have 1 type, ie. If I put different Material, everything will be "fine", but...

Regomy commented 2 months ago

Are you absolutely sure that you do not have bypass permissions or OP? At least 3 different checks should pick that up, not to mention that someone tested this for the 9.0.0 release. If possible, test with an another account to make sure that some permissions do not interfere. The log only shows the batch processors, which might be a bug as they do not fully bypass players with bypass permissions right now.

And yes... and no... :D

🥇 Most likely the point is that all of these items have 1 type, ie. If I put different Material, everything will be "fine", but...

how to get kick? https://youtu.be/XmCYgNeMTDY

config: https://gist.github.com/Regomy/78bba9383a438f86a8243b9b3af00cc0

Photon-GitHub commented 2 months ago

Thank you. I think I will add some more debug messages in the next version that will help me find the problem why MultiInteraction and PerfectExit don't react.

Photon-GitHub commented 2 months ago

9.1.0 has a lot more debug messages. Please retest on that version so I have more log messages to work with. Please use the FINER log level, like before.

Regomy commented 2 months ago

2024-05-15.log

Regomy commented 2 months ago

2024-05-15.log

@Photon-GitHub

Regomy commented 2 months ago

I wouldn't rely on multi interactions, for good measure, you haven't given any customization of this module, it's useless.... Any drag click, and my server is pvp 1.8 oriented, will just lead to false positives, yes even butterfly...

Regomy commented 2 months ago

https://youtu.be/C2AsqtQLbQU 2024-05-15.log

Regomy commented 2 months ago

https://youtu.be/TxL_jMpWiF4 2024-05-15.log

Photon-GitHub commented 1 month ago

This issue is kind of a mess. The latter comments are false positives and other stuff, so I will close this. Please report any remaining problems in their own issues.