Photon-GitHub / AntiCheatAddition

An anticheat with nieche checks to cover cheats usually not covered by anticheats.
GNU General Public License v3.0
152 stars 45 forks source link

ACA destroy schedulers? #606

Closed Regomy closed 2 months ago

Regomy commented 2 months ago

This server is running PandaSpigot version git-PandaSpigot-"858ab0f" (MC: 1.8.8) (Implementing API version 1.8.8-R0.1-SNAPSHOT) (Git: 858ab0f) Soup, Chest, AutoMessage, WorldEdit, ViaVersion, ProtocolLib, WorldGuard, LuckPerms, packetevents, Vault, TAB, Essentials video: https://youtu.be/pxEAxOBI0Uc automessage cmd code:


package me.rejomy.automessage.command;

import me.rejomy.automessage.Main; import org.bukkit.Bukkit; import org.bukkit.command.Command; import org.bukkit.command.CommandExecutor; import org.bukkit.command.CommandSender;

public class AutoMessageCommand implements CommandExecutor {

@Override
public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {
    if(args.length == 0) {
        sender.sendMessage("run нахуй");
        Bukkit.getScheduler().scheduleSyncDelayedTask(Main.getInstance(), () -> {
            Bukkit.broadcastMessage("я выполнился1");
        }, 30);

        Bukkit.getScheduler().scheduleSyncRepeatingTask(Main.getInstance(), () -> {
            Bukkit.broadcastMessage("я я тоже");
        }, 60, 60);
        return false;
    }

    return false;
}

}

Photon-GitHub commented 2 months ago

I am unsure if this is really my plugin or if this is due to some externalities. ACA only calls the scheduler to create tasks, not to cancel them. The only cancelling happens in LogBot, so if that is disabled, ACA does not modify any tasks. Might be packetevents, but I am really not sure how that happens.

Regomy commented 2 months ago

I am unsure if this is really my plugin or if this is due to some externalities. ACA only calls the scheduler to create tasks, not to cancel them. The only cancelling happens in LogBot, so if that is disabled, ACA does not modify any tasks. Might be packetevents, but I am really not sure how that happens.

I have no idea what the fuck that was, it's fine now on the same server :/

Regomy commented 2 months ago

Tried panda-spigot, flamepaper, 17 and 20 java, uploaded to hosting. I still have this problem.

It's alarming that last night (I had an evening), everything worked fine, I have a suspicion that it's time related, but tonight I'll check more from hosting.

On 1.16.5, 1.12.2 there is no problem, only 1.8.8

Regomy commented 2 months ago

image Photon, can u try this .jar? https://github.com/hpfxd/PandaSpigot/actions/runs/8577785005

ghost commented 2 months ago

image2

ghost commented 2 months ago

without aca, it work properly (1.8.8)

ghost commented 2 months ago

but it work on 1.12.2 with aca

ghost commented 2 months ago

plugin to test: https://workupload.com/file/sMUGgLB8uEa

ghost commented 2 months ago

THATS WHY MY SERVER CANT RUN DUEL MATCH, BECAUSE OF THIS PLUGIN

ghost commented 2 months ago

@Photon-GitHub

Regomy commented 2 months ago

8.2.0 also break schedulers...

ghost commented 2 months ago

Screenshot_1 SCHEDULERS DOESN'T NOT WORK, VERSION WITHOUT PACKETEVENTS, MY DUEL CAN'T START, BUT IF I DELETING ACA I SEE MY LOCAL TIME PLACEHOLDERS AND OTHER MOMENTS

ghost commented 2 months ago

not work because uses runable https://github.com/aBooDyy/LocalTime-Expansion/blob/master/src/main/java/net/aboodyy/localtime/DateManager.java

Photon-GitHub commented 2 months ago

I have no idea what is causing that. However, you can retry on 9.1.0 as I have checked to only use modern scheduler methods, remove a bukkitrunnable and cancel a bukkittask instead of a taskid. I don't know if that will help.

ghost commented 2 months ago

did you confirmed that bug?

Photon-GitHub commented 2 months ago

No. I cannot reproduce it.

ghost commented 2 months ago

No. I cannot reproduce it.

i can join to vc and can proof it.

ghost commented 2 months ago

it work only for 1.8

Photon-GitHub commented 2 months ago

I know you have the problem, but I cannot reproduce it locally. Also, I have no idea what exactly is causing it, as I do not cancel any tasks, just schedule them. For some reason 1.8.8 has a problem with that, all other versions do not.

ghost commented 2 months ago

Screenshot_9 seems work after new update

ghost commented 2 months ago

Screenshot_13 for some reason, it breaks the plugin during the day and you can't run it anywhere, but then it works again after some hours

ghost commented 2 months ago

@Photon-GitHub