search

Photon-HDF5 / phconvert

Convert Beker&Hickl, PicoQuant and other formats to Photon-HDF5
http://photon-hdf5.github.io/phconvert
Other
16 stars 14 forks source link

Added support for pt3 files #14

Closed talaurence closed 8 years ago

talaurence commented 8 years ago

Added support for pt3 files following the example of ht3

tritemio commented 8 years ago

Received, let me take a look.

xref: This PR addresses #13.

tritemio commented 8 years ago

By looking at it, it looks very good! I noticed you fixed a few typos and added some forgotten fields to the metadata, good catch! Thanks.

I'd like to run it on a test file before merging. Can you upload send me a sample test file that we can later include in phconvert example data files?

Later (another PR) we should also add a notebook to convert PT3 files. It should be a trivial modification from the HT3 notebook.

talaurence commented 8 years ago

Attached is a short file that you can use. If you plot a time trace you see a periodic signal. It is rather boring, and there is no actual lifetime information, but it can show you how it works.

I probably wouldn’t want to post this data to a web site, but you can take a look at it.

-Ted

From: Antonino Ingargiola notifications@github.com<mailto:notifications@github.com> Reply-To: Photon-HDF5/phconvert reply@reply.github.com<mailto:reply@reply.github.com> Date: Wednesday, April 20, 2016 at 1:30 PM To: Photon-HDF5/phconvert phconvert@noreply.github.com<mailto:phconvert@noreply.github.com> Cc: "Laurence , Ted A." laurence2@llnl.gov<mailto:laurence2@llnl.gov>, Author author@noreply.github.com<mailto:author@noreply.github.com> Subject: Re: [Photon-HDF5/phconvert] Added support for pt3 files (#14)

By looking at it, it looks very good! I noticed you fixed a few typos and added some forgotten fields to the metadata, good catch! Thanks.

I'd like to run it on a test file before merging. Can you upload send me a sample test file that we can later include in phconvert example data files?

Later (another PR) we should also add a notebook to convert PT3 files. It should be a trivial modification from the HT3 notebook.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHubhttps://github.com/Photon-HDF5/phconvert/pull/14#issuecomment-212591435

tritemio commented 8 years ago

Attaching files through github does not work, sorry, you can send me a private email. We need a dummy file that we can use for testing and to build a runnable notebook that a user can take and use with its own files by simply changing the file name. I doesn't need to be "interesting" data.

tritemio commented 8 years ago

Ok, I tested it with a PT3 file downloaded from https://github.com/paulmueller/FCS_point_correlator and it works as expected, merging.