search

Photon-HDF5 / phconvert

Convert Beker&Hickl, PicoQuant and other formats to Photon-HDF5
http://photon-hdf5.github.io/phconvert
Other
16 stars 14 forks source link

added support for timeharp260 files phu and ptu #33

Closed seb5g closed 5 years ago

seb5g commented 5 years ago

Hello, I have a timeharp260 in the lab from picoquant. I added support for it in this fork. It can load .phu files (histograms) and .ptu files (time tagging)

tritemio commented 5 years ago

Hi @seb5g,

thanks for your contribution. I am all in favor of adding additional decoding for PTU variants containing time-tagged data to phconvert. Note that phconvert is a library to decode and convert a variety of timetagged data into Photon-HDF5. I understand that many simply use the decoding abilities to read the file in memory, thats fine too. Your function to read histogram data would be the first of this kind to decode non-timetag data. I think that this is a good addition to the toolbox. However I don't see the point of adding a function in loader.py since these are function that load the data and preprocess it in a way that is suitable for saving it in Photon-HDF5, but histograms cannot be saved in Photon-HDF5.

So, if you could remove the function corellation_ptu() (sic) then I will evaluate the PR for merging.

Also note that your PR has conflicts because you probably applied the modifications to an old version of phconvert. Please reapply your mods to the latest version on master to solve the conflicts.

tritemio commented 5 years ago

Addressed in #34