bh_print_sys_params: update to python3 and other enhancements.

Photon-HDF5 / phconvert

Convert Beker&Hickl, PicoQuant and other formats to Photon-HDF5

http://photon-hdf5.github.io/phconvert

Other

16 stars 14 forks source link

bh_print_sys_params: update to python3 and other enhancements. #46

Closed dmopalmer closed 5 years ago

dmopalmer commented 5 years ago

Fix issue #45 to make bh_print_sys_params work with python3.
Accept the direct output of load_set() so that it is optional to extract ['sys_params']
Format with %g instead of %f so that typical values (e.g. 1e-11 seconds Time/Chan) are not displayed as zero.

tritemio commented 5 years ago

Thanks!

tritemio commented 5 years ago

@dmopalmer, please let me know what line to use to add you in the contributor's list in the README.

dmopalmer commented 5 years ago

Contributor: David Palmer (@dmopalmer)

Adding a useful test would require another change, so that print_sys_params can write to a file-object instead of just to stdout. (This change is worthwhile and simple, but not in the current pull).

tritemio commented 5 years ago

I'll add you to the contributors, thanks. Your original PR is already merged.

For a test, I was simply thinking of a smoke test to test that the function runs with no error, not checking what is printed. A smoke test would have caught this py2 vs py3 error a long time ago.

It is up to you. If you want to add a test I would merge it right away. You could take the chance to convert also the other test (there is only one so far :-() in test_bhreader.py to use the simpler pytest format. Such a contribution would be appreciated.