PhotonBursted / nu_plugin_vec

A Nushell plugin implementing vector operations
MIT License
2 stars 1 forks source link

Review error spans #4

Closed PhotonBursted closed 1 week ago

PhotonBursted commented 2 weeks ago

The plugin contains a few commands, which were initially implemented as core commands. Plugin commands have a slightly different interface, which means some of the spans have been haphazardly migrated. One of the major differences is that plugin commands don't actually contain spans for their arguments, as they have already been parsed!

This may mean that error messages thrown by the plugin now have spans that don't make a lot of sense. This should be reviewed an rectified in order to increase usability.