PhotonQuantum / pysjtu

The Python iSJTU client for Humans.
https://pysjtu.readthedocs.io/en/latest/
GNU General Public License v3.0
44 stars 3 forks source link

Selection course api implemented #5

Closed PhotonQuantum closed 4 years ago

pull-assistant[bot] commented 4 years ago
Score: 0.95

Best reviewed: commit by commit


Optimal code review plan (4 warnings)

     feat(selection): query available sectors      style: cleanup
feat(selection): query available classes
> `pysjtu/schemas/base.py` 76% changes removed in fix(selection): insu...
fix(selection): insufficient constraints
> `pysjtu/parser/selection.py` 50% changes removed in fix(selection): miss...
     feat(selection): (de)register classes
refactor: adjust schemas and models
> `pysjtu/models/__init__.py` 50% changes removed in style: code cleanup
     fix(utils): base64 before elfhash      test: add test for selection      fix(selection): silently fail when selection page is not available      fix(selection): query batch is not large enough      feat(selection): add cache for classes query      fix(selection): missing query params
test(selection): add mock api test
> `pysjtu/client/api/selection.py` 93% changes removed in style: code cleanup
     doc: update README.md      style: code cleanup

Powered by Pull Assistant. Last update f0232e5 ... 9b39437. Read the comment docs.