search

PhotonVision / photonvision-docs

Docs for PhotonVision, a free open-source vision processing software for FRC teams.
https://docs.photonvision.org
Creative Commons Attribution 4.0 International
25 stars 57 forks source link

Fix #185 #210

Closed democat3457 closed 2 years ago

democat3457 commented 2 years ago

Adds custom css file to change permalink icon fonts to FontAwesome, mimicking the theme of the WPILib docs

mdurrani808 commented 2 years ago

I don't think it's something we need custom CSS for, but I don't know why it isn't showing up on our end.

https://github.com/pradyunsg/furo/commit/ad5ad99e28f8039068bfef27bf6e605b1273af5c

Once I can build, I'll review and merge, but long-term id prefer to not use custom CSS if we can avoid it.

https://pradyunsg.me/furo/quickstart/#quickstart

See the # marker there

democat3457 commented 2 years ago

It's not showing up on our end because the default icon, for some reason, is a Font Awesome icon that uses special Unicode that can't display with the normal font of our text. We can change it to # like is done in the furo repository, but I didn't want to change it from the link icon that is supposed to show (and that WPILib uses. WPILib uses a different site theme, which is why it shows on their docs but not ours.) If you would rather change it to #, , § or a different Unicode character that works with the chosen fonts, then that can be done instead.

mdurrani808 commented 2 years ago

I see. the link icon is probably nicer then, will get this merged soon. Thank you for the help