PhotonVision / photonvision-docs

Docs for PhotonVision, a free open-source vision processing software for FRC teams.
https://docs.photonvision.org
Creative Commons Attribution 4.0 International
25 stars 57 forks source link

Add mention of installing libopencv-core4.6 dependency on Romi. #265

Closed smoser-frc closed 1 year ago

smoser-frc commented 1 year ago

The Romi image needs libopencv-core4.6 as it is a dependency of libphotonlibcamera.so on pi platform.

Fixes https://github.com/PhotonVision/photonvision/issues/748

smoser-frc commented 1 year ago

This is what @mcm001 suggested in discord. I feel like a fix in the install script would be both more user friendly and more "robust". The additional disk footprint at least on romi was only that package (~3.5M). Total dependency chain would be like 4.5M if there were none of its deps already on the system.

That said, If this produces working Romi, then I'm really happy with that. (I hope to test that completely on Thursday).

smoser-frc commented 1 year ago

https://github.com/PhotonVision/photonvision/pull/749 is a install.sh fix.

Only one or the other of these PRs is needed.

mcm001 commented 1 year ago

Actually let's go with the install script change. Like you said it's a pretty small package

mcm001 commented 1 year ago

Closing in favor of modifying the install script. Thanks for the awesome work!