search

PhotonVision / photonvision-docs

Docs for PhotonVision, a free open-source vision processing software for FRC teams.
https://docs.photonvision.org
Creative Commons Attribution 4.0 International
25 stars 57 forks source link

Example video in pipeline outputs 404s #346

Closed TheComputer314 closed 5 months ago

TheComputer314 commented 8 months ago

https://docs.photonvision.org/en/latest/docs/pipelines/output.html

https://docs.photonvision.org/en/_static/assets/offsetandmultiple.mp4

Expected behavior: For the mp4 at the link to exist Actual behavior: 404

TheComputer314 commented 8 months ago

typo lol

Sam948-byte commented 5 months ago

the path to the file in question has an extra ../

I will add this to my current PR

Sam948-byte commented 5 months ago

@mcm001 it doesn't look like this one got properly linked, as it's still open. You might want to go ahead and close it.

TheComputer314 commented 5 months ago

It appears to be working now on my end...?

Sam948-byte commented 5 months ago

I'm sorry, that might have been a bit confusing. When I said it didn't get properly linked, what I meant was that I didn't properly link the issue that you created to my PR. If it had linked correctly, the issue ought to have closed when the PR was merged. The link in the docs is fully functioning afaik. If you want to go ahead and close the issue, that works too.

TheComputer314 commented 5 months ago

Oh ok.