PhotonVision / photonvision

PhotonVision is the free, fast, and easy-to-use computer vision solution for the FIRST Robotics Competition.
https://photonvision.org
GNU General Public License v3.0
264 stars 180 forks source link

Calibrating to a resolution different to the one selected #1199

Open SuperSaurus1 opened 7 months ago

SuperSaurus1 commented 7 months ago

Describe the bug When a resolution of a higher resolution, ex. 1280x720 is selected for calibration, upon completion a calibration dataset is created for 424x240. Within the logs it sets the resolution for calibration to the lower resolution, despite the UI displaying the desired resolution.

To Reproduce Steps to reproduce the behavior:

  1. Run calibration
  2. Look at the data set
  3. Look at the logs

Screenshots / Videos If applicable, add screenshots to help explain your problem. Additionally, provide journalctl logs and settings zip export. If your issue is regarding the web dashboard, please provide screenshots and the output of the browser console. image photonvision-journalctl.txt

Platform:

Additional context This was replicated on both a clean image of the photon vision image, then with debian installation, with the exact same output, on all 4 of the Orange Pi's plugged in.

mcm001 commented 7 months ago

I think i need to see whats going on inside the UI too, Might need to set up a local dev environment and set some breakpoints inside the UI or add console.log's and stuff to troubleshoot this one

SuperSaurus1 commented 7 months ago

Not going to lie, not super sure what you mean by that but I'd be happy to help however I can

mcm001 commented 7 months ago

Better question to start out with since it's easier. Does this happen on a windows or Linux laptop or desktop, too?

The next step would be finding the spot in the frontend where the request to enter calibration is sent (probably inside of CameraCalibrationCard) and adding print statements to see if it does what you expect. If you put these changes in a pull request, GitHub actions will build a JAR that you can upload using offline update to test out, and you can look at the browser console to see your prints. That's how I would approach it