PhotonVision / photonvision

PhotonVision is the free, fast, and easy-to-use computer vision solution for the FIRST Robotics Competition.
https://photonvision.org
GNU General Public License v3.0
274 stars 190 forks source link

"Reset Samples" button for standard deviations freezes the page #1203

Closed Gold872 closed 7 months ago

Gold872 commented 9 months ago

Describe the bug On the web interface, if multiple tags are in view, the standard deviation always stays at "NaN/100 Samples", and hitting the "Reset Samples" button freezes the page, I have to refresh it to be able to change any other settings or view camera streams.

To Reproduce Steps to reproduce the behavior:

  1. Set up an 3D April Tag pipeline with multi-tag estimation turned on
  2. Have multiple tags in view
  3. Click on "Reset Samples"

Screenshots / Videos image

https://github.com/PhotonVision/photonvision/assets/91761103/2ba8252a-22d5-434c-9df3-d8955121b0fb

Platform:

Additional context This also seems to happen when running on a Raspberry Pi, but I couldn't get any footage of it.

DevonRD commented 7 months ago

This problem appears to happen regardless of whether there are targets in view, and seems to me like it is an infinite loop problem since both the backend and frontend throw no errors. Investigating further

DevonRD commented 7 months ago

Hunch was right, but that was a symptom of the real issue and not the cause. Another symptom was the standard deviations displaying the default zero values, as seen in screenshot/video. Fix incoming