Closed mcm001 closed 3 months ago
- test signs of pitch/yaw are still right
That should be tested here, no?
Yeah, but I had to flip the sign of the expected pitch and yaw in my unit test since I think it looked like crosshair location and target center location were flipped previously
Ah, yea. The testYawPitchBehavior()
test I linked seems to have it right regardless, though. Does addressing my first comment fix that issue in testYawPitchCalc()
then-- reverting the sign changes in the object point creation and negating the yaw/pitch signs in the assertion?
Takes anywhere from 1ms to 0.01ms on my Ryzen 4800h laptop. Since we only undistort one point I imagine it's super fast and most of that is JNI overhead
TODO