PhotonVision / photonvision

PhotonVision is the free, fast, and easy-to-use computer vision solution for the FIRST Robotics Competition.
https://photonvision.org
GNU General Public License v3.0
264 stars 180 forks source link

Calibration Discard Button #1262

Open MidgleyM opened 5 months ago

MidgleyM commented 5 months ago

Is your feature request related to a problem? Please describe. If you enter a bad calibration, and don't have the time to re-calibrate the camera, there is no easy way to get rid of that calibration quickly.

Describe the solution you'd like A button to discard the calibration would fix this issue. It could be placed next to the "import" and "export" buttons that are in the pop up that appears when you click on the resolution in the "Cameras" tab of the web UI.

Describe alternatives you've considered There are few solutions we have thought of for getting rid of the calibrations.

  1. Re-flashing the SD card. This would revert all settings and wipe everything.
  2. Mess with the settings file, and try not to mess anything else up.
  3. (only works with multiple cameras) Turn on "Match by known cameras only" setting, and flip the cameras port order around (e.g. camera on top port moved to bottom port, camera on bottom port moved to top port.) and swap their network table names and pipelines, to avoid the issue.
  4. Re-calibrate the camera. Can be time intensive, done incorrectly, or mess up tuning you've done for the robot.

Additional context My team discovered this issue when we wanted to import the camera calibrations from calibDB to our USB cameras, and wanted to import the calibration we got for 1200x720 to the 320x240 resolution. Some mentors said that it should work, but it would not import, so I changed the resolution the file said it was to 320x240, and that made it work, but it had very inaccurate values, and we discovered that there was no easy way to remove that calibration.

mcm001 commented 5 months ago

You can upload a correct calibration pretty easily as you've described? but yeah no easy way to delete a calibration, or disable its effects on 2d targeting.

gartaud commented 5 months ago

I agree that such feature would be useful.