search

PhotonVision / photonvision

PhotonVision is the free, fast, and easy-to-use computer vision solution for the FIRST Robotics Competition.
https://photonvision.org
GNU General Public License v3.0
260 stars 169 forks source link

Create NTLogAppender #1297

Open mcm001 opened 3 months ago

mcm001 commented 3 months ago

image

I don't think this adds much bandwidth, and massively helps debug photon when looking at wpilogs of NT data

based on #1298

mcm001 commented 3 months ago

It's super easy to must not send debug prints to NT, if we want?

srimanachanta commented 3 months ago

It's super easy to must not send debug prints to NT, if we want?

I meant more adding a UI toggle to handle logging to NT

mcm001 commented 3 months ago

Yeah idk. Unless teams see a legit value add from having photon logs in their wpilogs, I may punt on this one

srimanachanta commented 3 months ago

Yeah idk. Unless teams see a legit value add from having photon logs in their wpilogs, I may punt on this one

I think it would be useful, especially for teams that do log

TheTripleV commented 2 months ago

On 2nd thought, maybe the rio nt server will get bogged down. Logging rio console to wpilog via advantagekit slowed things down for us.

Instead, maybe it would be better for photonlib to publish the name of the wpilog and have photon live rename the log file to match what the wpilog is called.

mcm001 commented 2 months ago

That's decently clean. I do think we can reevaluate this come 2027 (ROSconsole, for example, is a thing and exists). Wanna make an issue to track auto-renaming logs instead? Or at the very least print in the log when valid match number is sent?