PhotonVision / photonvision

PhotonVision is the free, fast, and easy-to-use computer vision solution for the FIRST Robotics Competition.
https://photonvision.org
GNU General Public License v3.0
263 stars 184 forks source link

Example Rewrites #1310

Closed gerth2 closed 2 weeks ago

gerth2 commented 5 months ago

Is your feature request related to a problem? Please describe. Examples are out of date.

Describe the solution you'd like Better examples (see below).

Describe alternatives you've considered No.

Additional context

Per some discord/champs discussion, there is a need to rewrite the examples to be more modern. Here's my initial list of wants:

1) Support C++, Java, Python 2) Support apriltags (only) 3) Support 4-module swerve drive 4) Be simulatable out of the box 5) "Hide" the simulation code as best as possible so the new users aren't distracted 6) Continue paradigm of demonstrate in Timed-based (and let user convert to command if needed)

Label/order examples from "Simple" to "Advanced" with some supporting docs indicating that Simple isn't bad, Simple still scores points, Advanced has more capability but might need more effort/debug, etc...

But otherwise.... keep the flow similar to what we have today.

1) Point at Target (button for switching rotation control to center a certain ID tag in the field of view) 2) Translate to Target (button switching x/y vel to get a certain tag id in a certain spot in the field of view) 3) Estimate pose & Drive to Position (P control) 4) ?? wpilib trajectory plan to position?

gerth2 commented 3 weeks ago

Closed by #1408