search

PhotonVision / photonvision

PhotonVision is the free, fast, and easy-to-use computer vision solution for the FIRST Robotics Competition.
https://photonvision.org
GNU General Public License v3.0
264 stars 183 forks source link

Allow opencv8 distortion model in PhotonCamera #1317

Closed mcm001 closed 4 months ago

mcm001 commented 4 months ago

We previously assumed only OpenCV5 but mrcal uses opencv8

amquake commented 4 months ago

Is there a usecase for leaving the vector length unspecified instead of just changing 5 to 8 everywhere?

mcm001 commented 4 months ago

Opencv calibration is still set to opencv5. We could standardize on 8, maybe? Or can we just set higher level coefficients to zero?

amquake commented 4 months ago

Or can we just set higher level coefficients to zero?

👍