search

PhotonVision / photonvision

PhotonVision is the free, fast, and easy-to-use computer vision solution for the FIRST Robotics Competition.
https://photonvision.org
GNU General Public License v3.0
262 stars 166 forks source link

Mark generated files as generated in gitattributes #1337

Closed spacey-sooty closed 2 weeks ago

spacey-sooty commented 1 month ago

This tells git the files are generated, mostly useful for avoiding clogging up git diffs making reviewing code easier.

mcm001 commented 1 month ago

What's this do? (Just describe it in the PR comment body)

mcm001 commented 3 weeks ago

Those 3 files shouldn't even be committed in the first place, right?

GrahamSH-LLK commented 3 weeks ago

I’m not sure this does what you think. linguist is GitHub’s language detector, so this makes those files not factor into the GitHub language percentage. This doesn’t, however, do anything to git itself or diffing.

spacey-sooty commented 3 weeks ago

I’m not sure this does what you think. linguist is GitHub’s language detector, so this makes those files not factor into the GitHub language percentage. This doesn’t, however, do anything to git itself or diffing.

When I said diff I meant the diffs on GitHub.

Those 3 files shouldn't even be committed in the first place, right?

Don't think so

mcm001 commented 2 weeks ago

If they are never committed then I'm inclined to decline this PR

spacey-sooty commented 2 weeks ago

If they are never committed then I'm inclined to decline this PR

Ohh yeah I thought they were being commited right now...