Open gerth2 opened 3 years ago
Looks tied to using resolutions other than 320*420 on Shape pipeline - Threshold sliders also appear to stop working?
e7035b5de48
in https://github.com/gerth2/photonvision was used to create this, though I don't believe it's specific to that commit.
Really weird, can't reproduce this in test mode
Is this resolved now?
I believe yes, on phone and need to look up the PR... but latest on my PC we had found and corrected root cause
On Sat, Oct 2, 2021, 9:06 AM Matt @.***> wrote:
Is this resolved now?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PhotonVision/photonvision/issues/285#issuecomment-932757706, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABC7B3RNWTLIJKGI5JUOYJDUE4GUXANCNFSM5DO56ORA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Yup - fixed in this commit specifically: https://github.com/PhotonVision/photonvision/pull/288/commits/ea3e3189eff2248f1abd86a35f8aa36d751efd5e
Update: this can be worked around by just showing/hiding/showing the stream. Perhaps post 2022 - dig into these details more and see if we can fix it up
I was able to produce a case where the streams of the GPU threshold output and the overlay of target outlines don't match up in the overlay. To make a rough guess, it looks like one is being scaled at a different factor than the other?
I've not driven to root cause yet.
Settings:
photonvision-settings.zip