PhotonVision / photonvision

PhotonVision is the free, fast, and easy-to-use computer vision solution for the FIRST Robotics Competition.
https://photonvision.org
GNU General Public License v3.0
263 stars 181 forks source link

Driver Mode and Pipeline Commands change Network Tables but Not the UI v2023.1.2 #724

Open icemannie opened 1 year ago

icemannie commented 1 year ago

Using commands to set and reset Driver Mode and change Pipeline index causes the NT values to change but the UI doesn’t.

Changing the same settings in the UI don’t reflect in network tables.

Ornamus commented 1 year ago

I noticed this today too - and it looks like that while the Network table pipeline index is changing when set via code, the actual pipeline itself is not changing, which is making it impossible to change pipelines without using the Dashboard UI.

icemannie commented 1 year ago

It is essentially unusable in competition without the pipeline feature. The Driver Mode settings can be achieved through a pipeline.

mdurrani808 commented 1 year ago

Have you checked if this is only a visual bug or not? Ex. if you switch to pipeline 2 which is apriltag from pipeline 1 which is refelctive, do you start getting AprilTag data?

icemannie commented 1 year ago

I retested and both the pipelines and Driver Mode change as I would expect.

One thing I did notice - nothing to do with Photonvision- that could have caused me to think it wasn’t working earlier.

I use WPILIB Shuffleboard to watch values changing. To the left of that you can get Network Tables to appear. Tonight I could see values changing in the Network Tables but not on Shuffleboard. Looks like a WPILIB Bug.

On Tue, Jan 17, 2023 at 5:40 PM Mohammad Durrani @.***> wrote:

Have you checked if this is only a visual bug or not? Ex. if you switch to pipeline 2 which is apriltag from pipeline 1 which is refelctive, do you start getting AprilTag data?

— Reply to this email directly, view it on GitHub https://github.com/PhotonVision/photonvision/issues/724#issuecomment-1386244101, or unsubscribe https://github.com/notifications/unsubscribe-auth/AESZCOX6MEOPLEXCF42O2KDWS4UV3ANCNFSM6AAAAAATVX7OVE . You are receiving this because you authored the thread.Message ID: @.***>

mcm001 commented 1 year ago

Oh that's whacky. Does Glass work?

mcm001 commented 1 year ago

Just confirmed something is weird. I was able to toggle driver mode from Glass and from the web dash, but switching pipeline indexes doesn't seem to trigger the camera to change its video mode...

https://discord.com/channels/725836368059826228/725846784131203222/1069462210335744040

arielCheng218 commented 1 year ago

Please fix this soon if you can! I'm using PhotonVision v2023.4.2 and I'm having the same issue as @icemannie. Switching pipelines with setPipelineIndex only changes the pipelineIndex in NetworkTables, but not the web interface. Pipeline type doesn't seem to have anything to do with it too; switching between retroreflective piplines, a retroreflective and an apriltag pipeline, or two apriltag pipelines all don't work.

mdurrani808 commented 1 year ago

@arielCheng218 What version is your coprocessor on>

arielCheng218 commented 1 year ago

I'm using v2023.4.2 on Limelight 2

mcm001 commented 1 year ago

with v2023.4.2 with my Pi here locally running a NT server and robot simulation connected (also on 2023.4.2) I cannot reproduce. I can enable/disaable driver mode and switch pipeline indexes with setPipelineIndex OK.