PhotonVision / photonvision

PhotonVision is the free, fast, and easy-to-use computer vision solution for the FIRST Robotics Competition.
https://photonvision.org
GNU General Public License v3.0
278 stars 196 forks source link

[photonlib] Improve PhotonUtils #925

Open amquake opened 1 year ago

amquake commented 1 year ago

The current PhotonUtils class makes some assumptions about the camera's rotation relative to the robot, and does not support 3d geometry. Related issue: https://github.com/wpilibsuite/allwpilib/issues/4757

I previously attempted to update this class (link) while testing with trigonometry calculations in simulation to handle 3d geometry, but I'm not sure what the best user API would look like.

Note: these calculations would be affected by #896 !

mcm001 commented 1 week ago

@amquake this still relevant?