Resolve "Remove Unnecessary Data Files" - [merged] - Githubissues

Photonic-Architecture-Laboratories / si-photonics-toolkit

Photonic Integrated Design Package

MIT License

11 stars 0 forks source link

Resolve "Remove Unnecessary Data Files" - [merged] #9

Closed aycandv closed 2 years ago

aycandv commented 3 years ago

Merges 4-remove-unnecessary-data-files -> develop

Closes #4

aycandv commented 2 years ago

added 2 commits

015f6fb3 - updated data file and filename in trax_neff module
ecb5935d - Merge branch '5-update-neff-dataset' into 'develop'

Compare with previous version

aycandv commented 2 years ago

added 3 commits

edc32bfe - chore: delete neff.pickle
03b93c8e - chore: remove asymmetric coupling coefficient file and function
35b247d8 - chore: remove unused imports

Compare with previous version

aycandv commented 2 years ago

changed target branch from master to develop

aycandv commented 2 years ago

added 1 commit

279b16c6 - chore: remove dc through power function and data file

Compare with previous version

aycandv commented 2 years ago

added 5 commits

1c1dc48f - chore: update readme
95c96ace - chore: remove unused functions
8ec62796 - chore: add gitignore
eba827e4 - docs: update tutorial notebooks
f2199653 - style: remove unused parenthesis

Compare with previous version

aycandv commented 2 years ago

unmarked as a Work In Progress

aycandv commented 2 years ago

In GitLab by @esmagden on Nov 29, 2021, 11:29

Can we only use mode argument in the polarization_fraction function? How about neff and ng functions?

aycandv commented 2 years ago

We can only use mode argument in polarization_fraction function. We were able to use mode arg. in neff function with trax-incompatible data.

aycandv commented 2 years ago

In GitLab by @esmagden on Nov 30, 2021, 20:45

approved this merge request

aycandv commented 2 years ago

added 2 commits

acd471de - chore: add requirements and makefile
1f86654e - test: add tests

Compare with previous version

aycandv commented 2 years ago

added 1 commit

71bcb10a - test: add test

Compare with previous version

aycandv commented 2 years ago

added 1 commit

21b81d96 - chore: update makefile

Compare with previous version

aycandv commented 2 years ago

added 1 commit

b43f92c3 - chore: add effective index data

Compare with previous version

aycandv commented 2 years ago

added 1 commit

fc6b44e9 - feat: add new effective index functions

Compare with previous version

aycandv commented 2 years ago

added 3 commits

a7c96c9d - chore: add isort package to requirements
2c5a8efd - chore: update makefile
7060b7da - test: add new test cases

Compare with previous version

aycandv commented 2 years ago

added 2 commits

19ce7172 - chore: add new effective index data
f6111b5a - chore: add new effective index data

Compare with previous version

aycandv commented 2 years ago

merged

aycandv commented 2 years ago

mentioned in commit 446142531fb27fc64b200c2c9b9c5cc8dcd99c8a