search

Photonsters / PhotonFileEditor

Utilities to display, make and edit files for the Anycubic Photon printer
GNU General Public License v3.0
75 stars 13 forks source link

Preview Context image not working #57

Closed X3msnake closed 6 years ago

X3msnake commented 6 years ago

image

Preview0 - 1691x875 Preview1 - 198x101

Also it would be great to be able to context import/export both preview images, at his moment on the full export you get only one of the images and should get the 2 images

NardJ commented 6 years ago

Export of both previews is implemented. Import of previews is pending.

image

NardJ commented 6 years ago

Importing new preview images is now possible using Replace Bitmap if preview image is visible. (Branch Fix-and-Features)

X3msnake commented 6 years ago

@NardJ Awsome work master

Love the way you managed the disclaimer ;)

Ok both images are in fact exporting but they are exporting at the wrong size

Preview Zero is 360x186 and is ok Preview One is 360x183 and should be 198x101

NardJ commented 6 years ago

@X3msnake: The export size of the preview images was indeed wrong. Fixed this now, however...

I find that all photon files have different sizes for preview0 and preview1. Is this correct that you know? (I also checked with 010 Editor and customized template below.)

anycubic-photon-hextemplate.txt

X3msnake commented 6 years ago

@NardJ

If you mean that the preview 1 is different from prev0 then this is correct all files will have diff sizes between these images

Since the smaller is used by the photon to show a preview along other files and the bigger one is shown when you select it.

If the size varies between files the it shouldnt happen and we may have something wrong in the decoding

NardJ commented 6 years ago

@X3msnake A fault in decoding the image height and width (byte 6Ch and 70h for preview0) would result in a garbled decoding of the raw image data (bytes from 8Ch for preview 0). Also viewing several files with the (modified) 010 template show the same differences of size between several fresh Preview0 images. Could you verify you get the same different image sizes of the large preview images?

X3msnake commented 6 years ago

@NardJ how can I verify this?

@Andoryuuta @Rob2048 @Reonarudo

Do you have any knowlage why this might be happening?

Andoryuuta commented 6 years ago

I'm not sure that I fully understand the issue, but I can verify that the preview image width, height, and number of bytes it takes to store them varies depending on the file.

Here are the results from two different files:

reed.photon :
previewHeader Width:0x59c, Height:0x206, PreviewDataOffset:0x8c, PreviewDataSize:0x1780e, Field_10:0x0, Field_18:0x0
thumbnailHeader Width:0xc6, Height:0x45, PreviewDataOffset:0x178ba, PreviewDataSize:0x11c6, Field_10:0x0, Field_18:0x0

PHOTON.photon :
previewHeader Width:0x5a6, Height:0x399, PreviewDataOffset:0x8c, PreviewDataSize:0x645c4, Field_10:0x0, Field_18:0x0
thumbnailHeader Width:0xc6, Height:0x7f, PreviewDataOffset:0x64670, PreviewDataSize:0x33de, Field_10:0x0, Field_18:0x0

I never looked into how the slicer actually renders the initial preview QT image from the scene, but I know that it scales the thumbnail image right before it encodes it. (See the partially decompiled/pseudo-code here https://gist.github.com/Andoryuuta/010a64c283350e254a8fc1369dfb1396#file-previewencoding-cpp-L119-L148)

NardJ commented 6 years ago

@Andoryuuta This is what we meant. I think we will have to test if PFE files with edited preview images load correctly on the photon. If so I will close this issue.

NardJ commented 6 years ago

Just tested and preview images display garbled.

Andoryuuta commented 6 years ago

@NardJ On which .photon file and which commit/branch/fork?

NardJ commented 6 years ago

@Andoryuuta Branch fixes-and-features. I tested with smilie.photon where I replaced preview images with for instance the preview images from benchy.photon.

Reonarudo commented 6 years ago

Do you have any info about the different sizes between the images? On my tests, there was no constant ration between them. Also is there any size limit like the screen size?

NardJ commented 6 years ago

@Reonarudo, @Andoryuuta: I just did some testing. I used Smilie.photon as base file with the following results:

cat199x136 cat543x401

X3msnake commented 6 years ago

Probably the nr pf colours. It must be a indexed 256 gif

No dia domingo, 8 de julho de 2018, Nard Janssens notifications@github.com escreveu:

@Reonarudo https://github.com/Reonarudo, @Andoryuuta https://github.com/Andoryuuta: I just did some testing. I used Smilie.photon as base file with the following results:

  • Export preview 0 and replace preview0 with exported image -> Loads succesfully on Photon
  • Resave exported image to png with GIMP. Replace preview0 with resaved image -> Loads succesfully on Photon
  • Replace preview 0 and eventually also preview 1 with other images but of same size (see below). Found a bug where in the preview[1] data block the raw data address was not updated on replace of preview 0. Fixed this in the OpenGL branch (derivative of Fixed-and-Features). Result is this photon file: Smilie._replaced543x401.photon.zip https://github.com/NardJ/PhotonFileUtils/files/2174050/Smilie._replaced543x401.photon.zip All addresses are fine in my opinion. Photon show preview image a little less garbled (less condensed to upper part of preview) but nonetheless still garbled. This makes me wonder if we are missing something about the compresseion of the images.

[image: cat199x136] https://user-images.githubusercontent.com/11459480/42423257-beb6ef54-82f7-11e8-9ecf-d015de52146b.png [image: cat543x401] https://user-images.githubusercontent.com/11459480/42423258-becf03a0-82f7-11e8-9fff-3d3dd28611c0.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NardJ/PhotonFileUtils/issues/57#issuecomment-403312120, or mute the thread https://github.com/notifications/unsubscribe-auth/AKke-g0aX8unGHkRAALOBGbYLJyHaXJhks5uEmIegaJpZM4U8WDL .

-- Com os melhores cumprimentos, Vinicius Silva

X3msnake commented 6 years ago

Something is really screwy here

I exported a image and then imported it again and the end value changed...

image image

here's the before and after file photonfilechangetest.zip

NardJ commented 6 years ago

It seems the photon displays preview 1 (and not 0 as I assumed). On exporting preview 1 replacing preview 1 with this exported version, the preview is not displayed correctly on the photon.

NardJ commented 6 years ago

@X3msnake @Reonarudo @Andoryuuta It seems that the bytes which hold the nr of repeating pixels needed extra bits. The high byte has 4 high bits which are not needed for encoding the repeat-nr but should read 0011.

Fixed this (in OpenGL branch) and tested replacing previews of smilie.photon with same resolution images. This works now. Smilie._replacedboth.photon.zip

Further testing with replacing by different resolution images was also succesfull!

X3msnake commented 6 years ago

Awsome :D

We can brand the example files that ship with the sw :P

2018-07-09 11:06 GMT+01:00 Nard Janssens notifications@github.com:

Closed #57 https://github.com/NardJ/PhotonFileUtils/issues/57.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NardJ/PhotonFileUtils/issues/57#event-1722738550, or mute the thread https://github.com/notifications/unsubscribe-auth/AKke-n9hVqEVi8yIED7USn-pT1c_Yfa5ks5uEysogaJpZM4U8WDL .

-- Com os melhores cumprimentos, Vinicius Silva