Closed cwoac closed 2 years ago
OK. While I'm fairly sure that more changes will be needed / wanted, it's now at a point where it can be submitted for review. I believe functionally it all works...
I loaded an SL1 and a .photon and in both cases when I hit "Information" nothing happens. No crash, but expected behavior is the dialog shown in the README.md.
I loaded an SL1 and a .photon and in both cases when I hit "Information" nothing happens. No crash, but expected behavior is the dialog shown in the README.md.
As per the side thread, turns out to have been an issue with the form code and how intellij now injects the generated code, the changes since then should resolve it.
Is it possible to have support for ctb files added?
Is it possible to have support for ctb files added?
Not in this PR. Once it's merged, then adding CTB is doable, but this change is big enough as it is
OK, I've managed to reproduce @X3msnake's mid load hang*, and basically it is an oom. I'm not sure what/whether to try to address it here or in a follow-on issue -thoughts?
*I reproduced it symptomatically at least.
not suere if the JAR was updated but i am getting a loading stuck while trying to open a SL1 file
And there is a wrong offset to the mouse tip on the pixel edit
As a Feature request, would you add the capability of the pencil painting pixels while mouse is pressed and dragged? is it hard to make this feature?
As a Feature request, would you add the capability of the pencil painting pixels while mouse is pressed and dragged? is it hard to make this feature? It can be looked into, certainly. I'd suggest raising a separate issue for it.
So, the issue being seen is that I developed this against prusaslicer 2.2, and since then 2.3 has come out which changes the sl1 format.
The plus side is that this adds thumbnails to the format; the downside is it also adds a new information file in addition to the config.ini file.
let me know when i can test this and please fix the pencil offset also so we can merge this PR.
thanks for all your contribution :)
No dia terça-feira, 5 de maio de 2020, Oliver Matthews < notifications@github.com> escreveu:
So, the issue being seen is that I developed this against prusaslicer 2.2, and since then 2.3 has come out which changes the sl1 format.
The plus side is that this adds thumbnails to the format; the downside is it also adds a new information file in addition to the config.ini file.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Photonsters/PhotonFileValidator/pull/65#issuecomment-623998070, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUR56XCGNYPSINSVMYM6QTRP7ZSNANCNFSM4LNFVM2A .
-- Com os melhores cumprimentos, Vinicius Silva
OK, so this abstracts out the loading and saving code so that we can read / write multiple different formats, while leaving the internal format used untouched. I've kept the photon code (obviously), and added chitubox '.zip' file support and prusaslicer '.sl1' format support. This would enable looking at the other formats being requested, but they should probably be in follow on PRs.
Relevant points:
SlicedFile
andSlicedFileHeader
as well as adding any needed new values to theEParameters
enum and a new entry to theEFileType
enum, and appropriate case values inSaveDialog::onOK
andSlicedFile::readFile