multiple file format support for #47

cwoac commented 4 years ago

OK, so this abstracts out the loading and saving code so that we can read / write multiple different formats, while leaving the internal format used untouched. I've kept the photon code (obviously), and added chitubox '.zip' file support and prusaslicer '.sl1' format support. This would enable looking at the other formats being requested, but they should probably be in follow on PRs.

Relevant points:

I've done no gui rework at all. There probably should be some, but I'm uncertain exactly what. Maybe a dropdown in the save for selecting target file type?
To add additional formats, you need to subclass + implement versions of SlicedFile and SlicedFileHeader as well as adding any needed new values to the EParameters enum and a new entry to the EFileType enum, and appropriate case values in SaveDialog::onOK and SlicedFile::readFile
Target file format is determined based on file extension
Image based formats are loaded at an AA level of 4 (this is one point where a GUI option might be good).
I've checked conversion between photon, zip and sl1 formats (each direction).
I've done several test prints of sl1 files (with and without AA) converted to photon. I don't have any of the other hardware to test with.
When converting from sl1 files, it just creates block colour previews (I might alter this to try and put the filename in text or something.
The code is probably suboptimal performance wise, especially in writing png images - there are probably tricks that can be done using rasters to blend the AA layers together.

cwoac commented 4 years ago

OK. While I'm fairly sure that more changes will be needed / wanted, it's now at a point where it can be submitted for review. I believe functionally it all works...

MakerMatrix commented 4 years ago

I loaded an SL1 and a .photon and in both cases when I hit "Information" nothing happens. No crash, but expected behavior is the dialog shown in the README.md.

cwoac commented 4 years ago

I loaded an SL1 and a .photon and in both cases when I hit "Information" nothing happens. No crash, but expected behavior is the dialog shown in the README.md.

As per the side thread, turns out to have been an issue with the form code and how intellij now injects the generated code, the changes since then should resolve it.

SammMoney commented 4 years ago

Is it possible to have support for ctb files added?

cwoac commented 4 years ago

Is it possible to have support for ctb files added?

Not in this PR. Once it's merged, then adding CTB is doable, but this change is big enough as it is

cwoac commented 4 years ago

OK, I've managed to reproduce @X3msnake's mid load hang*, and basically it is an oom. I'm not sure what/whether to try to address it here or in a follow-on issue -thoughts?

*I reproduced it symptomatically at least.

X3msnake commented 4 years ago

not suere if the JAR was updated but i am getting a loading stuck while trying to open a SL1 file

And there is a wrong offset to the mouse tip on the pixel edit

SupportsTester

As a Feature request, would you add the capability of the pencil painting pixels while mouse is pressed and dragged? is it hard to make this feature?

cwoac commented 4 years ago

As a Feature request, would you add the capability of the pencil painting pixels while mouse is pressed and dragged? is it hard to make this feature? It can be looked into, certainly. I'd suggest raising a separate issue for it.

cwoac commented 4 years ago

So, the issue being seen is that I developed this against prusaslicer 2.2, and since then 2.3 has come out which changes the sl1 format.

The plus side is that this adds thumbnails to the format; the downside is it also adds a new information file in addition to the config.ini file.

X3msnake commented 4 years ago

let me know when i can test this and please fix the pencil offset also so we can merge this PR.

thanks for all your contribution :)

No dia terça-feira, 5 de maio de 2020, Oliver Matthews < notifications@github.com> escreveu:

So, the issue being seen is that I developed this against prusaslicer 2.2, and since then 2.3 has come out which changes the sl1 format.

The plus side is that this adds thumbnails to the format; the downside is it also adds a new information file in addition to the config.ini file.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Photonsters/PhotonFileValidator/pull/65#issuecomment-623998070, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUR56XCGNYPSINSVMYM6QTRP7ZSNANCNFSM4LNFVM2A .

-- Com os melhores cumprimentos, Vinicius Silva

Photonsters / PhotonFileValidator

multiple file format support for #47 #65