search

Photonsters / Universal-Photon-Network-Controller

Network Controller for Anycubic Photon
GNU General Public License v3.0
37 stars 6 forks source link

Slow upload compared with the old sender #16

Open X3msnake opened 5 years ago

X3msnake commented 5 years ago

So for some reason uploading the 19MB file with the latest release takes ages, while uploading with the old sender takes about 2 minutes

Another thing i found is that the new version does not show the rest of the files on the USB.

I believe you made it intentional? but it should at least have the possibility to run all runnable photon files, likr the Update.bin, .LCD and .Gcode

image

image

lagnajeet commented 5 years ago

I tested the issue. It's not a bug. Disable logging and the file upload is 5 times faster than with logging enabled. The logging function is only there to catch errors. there is no need to have it enabled if not needed.

image

lagnajeet commented 5 years ago

For listing of files, i didn't put a check for .photon files but I did put a check that won't show files that are reported to be of size zero. I can disable that check and it will show all files.

X3msnake commented 5 years ago

awsome, thanks Master

No dia quinta-feira, 19 de setembro de 2019, Lagnajeet Pradhan < notifications@github.com> escreveu:

For listing of files, i didn't put a check for .photon files but I did put a check that won't show files that are reported to be of size zero. I can disable that check and it will show all files.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Photonsters/Universal-Photon-Network-Controller/issues/16?email_source=notifications&email_token=ACUR56UKQSZEMWYR5T2KE5LQKM2CPA5CNFSM4IVXEIL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7CVP3Q#issuecomment-533026798, or mute the thread https://github.com/notifications/unsubscribe-auth/ACUR56V4W3YERAODLVHOOQTQKM2CPANCNFSM4IVXEILQ .

-- Com os melhores cumprimentos, Vinicius Silva

ruralaccent commented 4 years ago

Are you able to add show all files as an option in settings? Also, is it possible to show folders, not just files, so we can order and arrange files, rather than just have one long list?

bgyarfas commented 3 years ago

I tested the issue. It's not a bug. Disable logging and the file upload is 5 times faster than with logging enabled. The logging function is only there to catch errors. there is no need to have it enabled if not needed.

This is the solution, you'll also see all the other operations speed up as well. For some reason the call to saveLog opens and closes the log file on every call! Adds about 100ms of latency for every packet.