g105b
commented
11 years ago Thanks for the issue, I had noticed this some time ago but forgotten all about it!
The error was being caused by trying to access the go parameters on a 404 page, as they are not all sent to the PageCode when the page doesn't exist.
The PHP.Gt errors are fixed, by sending EmptyObject instead, where appropriate, but your app will still need a tweak to fix it, as you'll still probably be assuming that $dom["something"] will be returning a DomEl.
To get around this, you'll simply have to extract the non-critical part of the _Common PageCode to the endGo function, which is called after the response is fully built (and so on 404 errors, the code will never fire). I had a look at your _Common.php, and it should look something like the following:
public function go($api, $dom, $template, $tool) {
// Check if user has clicked logout button.
if(isset($_REQUEST["Logout"])) {
error_log("User-initiated logout of appUserID " . $_SESSION["appUserID"]);
$this->logout();
header("Location: /");
exit;
}
$this->_security = $tool["Security"];
$this->_pageReq = strtok($_SERVER['REQUEST_URI'], '?');
$this->_pageReq = strtok($this->_pageReq, '#');
$this->_pageReq = str_replace("/", "\/", $this->_pageReq);
$appUser = $this->checkUser(
$tool["User"],
$api["AppUser"],
$dom,
$template["Tickler"]
);
}
// All of the code that *doesn't* need to be fired on 404 pages:
public function endGo($api, $dom, $template, $tool) {
$dom["body"]->appendToAttribute("data-version", $appUser["ID"]);
// Allows a mentor to view the plan of a user.
if(isset($_GET["MentorViewExit"])) {
error_log("Mentor " . $_SESSION["appUserID"]
. " stopping viewing plan of " . $_SESSION["planOwnerID"]);
$_SESSION["planOwnerID"] = $_SESSION["appUserID"];
}
...
...
...
}
8w
I've just noticed that if I hit an invalid URL in our app, the _Common.php still gets run (which might be fine?) but that there is then an error/ exception in the DalEl class - which means the 404 page doesn't get presented, the user gets a blank (white) screen.
Stack trace is: