search

Phrynohyas / eve-o-preview

An EVE client window switcher tool created to aid playing with multiple clients in CCP game EVE Online
https://forums.eveonline.com/t/eve-o-preview/4202
MIT License
293 stars 108 forks source link

Fix for preview flicker bug #186

Closed moldyleftovers closed 3 years ago

moldyleftovers commented 3 years ago

this should fix issue #185 by treating a null foreground window handle as an eve client, and only hiding previews when the foreground client is non-null and non-EVE.

Phrynohyas commented 3 years ago

Unfortunately it is only a part of the solution required GetForegroundWindow might return zero, however there are some other actions that have to be taken, like considering EVE-O Preview as an app that should not cause previews to hide, ad adding a delay before previews are hidden

moldyleftovers commented 3 years ago

Sure, seems that there are probably other enhancements that would help improve the user experience around this. Would you be willing to accept this change independently of those? As far as I can tell this change is a strict improvement in the behavior of Eve-O-Preview.

moldyleftovers commented 3 years ago

Also in practical terms this does actually resolve the specific problem of the previews hiding and reappearing when you switch directly from one preview to another by clicking on the preview.

The other two issues you mentioned seem like separate problems/feature requests actually. Not hiding when the Eve-O-Preview window is selected seems also good, but a separate concern. Adding a delay before hiding would not affect this specific bug, and using a delay instead of this fix seems less ideal because you then have to tune the delay independently for every use case. This change requires no tuning and just works for the most basic use case.

Phrynohyas commented 3 years ago

Would you be willing to accept this change independently of those? As far as I can tell this change is a strict improvement in the behavior of Eve-O-Preview. Not exactly the change but its concept (skipping the update cycle if the foreground window query returns NULL (IntPtr.Zero) ). I just moved the check to another place

вт, 30 мар. 2021 г. в 19:47, moldyleftovers @.***>:

Also in practical terms this does actually resolve the specific problem of the previews hiding and reappearing when you switch directly from one preview to another by clicking on the preview.

The other two issues you mentioned seem like separate problems/feature requests actually. Not hiding when the Eve-O-Preview window is selected seems also good, but a separate concern. Adding a delay before hiding would not affect this specific bug, and using a delay instead of this fix seems less ideal because you then have to tune the delay independently for every use case. This change requires no tuning and just works for the most basic use case.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Phrynohyas/eve-o-preview/pull/186#issuecomment-810415584, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKVEY7B4QE6RYTYNKVWOITTGH6BPANCNFSM4YT2U3GA .

moldyleftovers commented 3 years ago

ah great, ok thanks then. should I close this PR then?

Phrynohyas commented 3 years ago

Closing the pull request. The code from it goes as part of commit for #185 (there's way more changes than just this one, still it is one of the most important changes there)