Submission for assignment 3

[PhuongXmaster]

/cc @coderschoolreview

[coderschoolreview]

Thank you for your Ruby submission, PhuongXmaster!

:sweat: Unfortunately there are some problems with your submission:

• I couldn't find a walkthrough GIF referenced from your README.md. Please use RecordIt or LICEcap to record an animated GIF of your app in action, and include it in your README.md.

[harley]

:+1: Great job!!! I really admire your efforts in whipping this assignment to shape. Every little detail counts! I love the care you've put in this submission :bow:

You have a lot of great stuff in this code base. I have many things to like:

• good clean routes
• nice factories for testing!!
• nice yml fixtures with the use of erb
• good, clear heroku app name
• great job setting up devise to log in via username or email
• validation and custom validations
• use of I18n.t
• use of shoulda matchers and collection matchers

Suggestions:

• in events_controller.rb, it is actually common (and a decent choice) to set common variables via a before_action. However, I encourage you to keep things simple when the syntax becomes to a little complex. For example, instead of before_action :set_event, only: [:show, :edit, :update, :destroy], it will be clearer if we just put @event = Event.find params[:id] in each of the 4 actions above. See more here http://craftingruby.com/posts/2015/05/31/dont-use-before-action-to-load-data.html
• now that we've covered, I18n, you can support more than one languages on the site!
• it's better to put the TicketsController#available_ticket method in TicketType model instead. That way, you can just use @ticket_type.available_ticket without any arguments.
• event card looks too small on mobile screen:

cc @coderschoolreview @chug2k