search

Phylliade / ikpy

An Inverse Kinematics library aiming performance and modularity
http://phylliade.github.io/ikpy
Apache License 2.0
695 stars 152 forks source link

Fix compatibility of deprecated function for retrocompatibility #86

Closed ymollard closed 4 years ago

ymollard commented 4 years ago

Here's a patch following https://github.com/Phylliade/ikpy/issues/77 You might want to add some deprecation warning somehow. Meanwhile this function should be kept for retrocompatibility, we currently don't see how to use get_urdf_parameters instead.

Phylliade commented 4 years ago

Hello @ymollard, since some tests are not passing, i have to add some changes; It appears i cannot do it on a forked branch;

Is it ok for you if i recreate a local branch so we can both work on it?

ymollard commented 4 years ago

Sure! That one?

Phylliade commented 4 years ago

Yep exactly!