PhysiCell-Tools / PhysiCell-Studio

PhysiCell Studio is a graphical tool to allow easy editing of a (XML) model, create initial positions of cells, run a simulation, and visualize results. To contribute, fork and make PRs to the development branch.
GNU General Public License v3.0
22 stars 13 forks source link

things to fix #30

Open rheiland opened 1 year ago

rheiland commented 1 year ago
drbergman commented 4 months ago

colorbar for .mat coloring of cells seems to be located and sized by pixels, rather than normalized units sometimes causing it to enter the axes:

image
rheiland commented 4 months ago

I noticed something similar a couple days ago which makes me think recent edits have caused it as it used to display properly. Not sure what may have caused it. One obvious debug is to test with previous releases. Edit: Maybe I was wrong. Maybe this annoyance was always present but it just didn't show up unless one resized the plotting window in various ways.

rheiland commented 4 months ago

In this release, https://github.com/PhysiCell-Tools/PhysiCell-Studio/releases/tag/v2.32.0, we introduced colorbars for cells' discrete scalars. Testing the release just before that (2.31.2), we don't see the weird placement of that lower colorbar. I imagine @vincent-noel is swamped with other things right now (as most of us are), but FYI. Positioning colorbars on resizable windows is tricky, but hopefully there's some "tight" mpl magic that will work.

cbars1 cbars2
rheiland commented 4 months ago

and this screenshot shows the situation using the latest release, with discrete scalars colorbar essentiall going out-of-view on a window resize.

cbars3
vincent-noel commented 4 months ago

Yes, I noticed it too. It's on my todo list, but I couldn't find time yet...

rheiland commented 3 months ago

I've spent a LONG time looking at possible fixes for the colorbars and the discrete scalars legend. If anyone has time to test, it's in https://github.com/PhysiCell-Tools/PhysiCell-Studio/tree/dev-colorbars . I still need to test for physiboss vis... actually, I'm hoping Vincent or Marco can test as they know it best.

Screenshot 2024-05-13 at 1 23 04 PM Screenshot 2024-05-13 at 1 24 05 PM
drbergman commented 3 months ago

This fixes it for me on my m2 mac!

vincent-noel commented 3 months ago

Thanks Randy ! I'll have a look asap