PhysicalAddons / physical-starlight-and-atmosphere

issue tracker
16 stars 2 forks source link

Fireflys in viewport and rendered image #22

Closed nikocraft closed 4 years ago

nikocraft commented 4 years ago

Describe the bug Fireflys are visible on in both viewport and rendered images.

General information

To Reproduce Turn on Physical Atmosphere, add a plane. Use these settings image

Screenshots [If applicable, add screenshots to help explain your problem.] image

Noticable even in the viewport

image

karlisup commented 4 years ago

Hi @nikocraft, Unfortunately using Cycles in combination with scenes that have low light levels will cause fireflies. Currently, I can suggest only widely known solutions mentioned in this StackExchange post.

I reproduced the bug and the solution I thought most effective was playing with Clamping (under Reder Properties). Although the output sun color has changed drastically I managed to get rid of the fireflies. It may be a solution in some cases but in some would not solve the issue at all.

clamped-sun clamped-sun2

Did you have an opportunity to try Bkjernisted proposed solutions:

Would be very interested if they produced better results.

nikocraft commented 4 years ago

I'll test your suggestion today and will let you know the results.

nikocraft commented 4 years ago

I'll test Bkjernisted proposal today as well, thanks for feedback! 👍

nikocraft commented 4 years ago

Hi @karlisup I tried Bkjernisted solution. With between 600-900 samples basically 99-100% of fireflys are gone. With 64 samples and Super Image Denoiser, I get again 99% fireflys gone, if I increase samples to 128 then it's very hard to get any fireflys. Here is 64 samples and only one blured out firefly.

image

Same render with 90 samples and I can't spot any fireflys, this is thanks to Super Image Denoiser which wipes them out after it runs.

image

karlisup commented 4 years ago

I am really glad that these solutions worked out!

schroef commented 2 years ago

What some other render engines do, is render the image larger and than scale down the image. My old render engine Thea Render had this build it. it would render at 2x or 4x. Yes takes longer, but really is good getting away with these fire flies. you can always do some tests. If the scene is not to difficult and detailed, you can always retouch it later in a photo-edit application. Or use a blurred image with painted mask to mask those parts out