search

PhysicalAddons / physical-starlight-and-atmosphere

issue tracker
16 stars 2 forks source link

Alpha is "catching " the fog #45

Closed Kubanis closed 2 years ago

Kubanis commented 3 years ago

Describe the bug I've found a big issue. Material based fog is a great thing, but it's not working with transparent materials. As you can see in the video - I have planes with textures and alpha but transparent part of the material are "catching" the alpha and when I intensify the effect, problem is very obvious, or when the plane is in big distance... To avoid that, I can make a workaround to make a mix sahder and plug alpha like a factor (you can see in the video), but when I make another material, addon will refresh/rewire everything automatically and my workarounds are lost...

General information

To Reproduce Make scene with planes with alpha and turn on material fog

Screenshots https://youtu.be/UAhJJJAy7K0

karlisup commented 3 years ago

Hi @Kubanis, Thank you for your patience! Initially, the issue title confused me as we already fixed one issue regarding alpha and how it interacts with the fog. It seems that during a merging process of various versions we have lost changes that fixed this bug - Sorry! We'll fix this first thing for the upcoming version and I'll ask Martinsh if the fix is quick enough to apply also for 1.3.1 (stable version).

Kubanis commented 3 years ago

Amazing - can't wait for it - thank you for reply :)

On Thu, Jul 29, 2021, 11:49 Karlis Upitis @.***> wrote:

Hi @Kubanis https://github.com/Kubanis, Thank you for your patience! Initially, the issue title confused me as we already fixed one issue regarding alpha and how it interacts with the fog. It seems that during a merging process of various versions we have lost changes that fixed this bug - Sorry! We'll fix this first thing for the upcoming version and I'll ask Martinsh if the fix is quick enough to apply also for 1.3.1 (stable version).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PhysicalAddons/physical-starlight-and-atmosphere/issues/45#issuecomment-888974113, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATABR5RGKKL34SKRBDCGSSDT2EP2NANCNFSM472SACBA .

karlisup commented 3 years ago

Hi @Kubanis, We have added the fix to v1.4.2-beta, but I've not closed the issue as it has not yet been applied to the stable 1.3.1. Have you tried out v1.4.2-beta?

Kubanis commented 3 years ago

Hi, thank you for letting me know - I will test that and let you know... meanwhile I've made my own script to make an air shadergroup in every shader for me...

Jakub

On Tue, Sep 7, 2021 at 5:08 PM Karlis Upitis @.***> wrote:

Hi @Kubanis https://github.com/Kubanis, We have added the fix to v1.4.2-beta, but I've not closed the issue as it has not yet been applied to the stable 1.3.1. Have you tried out v1.4.2-beta?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PhysicalAddons/physical-starlight-and-atmosphere/issues/45#issuecomment-914390542, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATABR5VDQWLQBFEYP6SJUQDUAYTGXANCNFSM472SACBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--

Jakub Javora CEO, Paranormal s.r.o.

+420 608484954 <+420+608484954> | @.*** Žirovnická 3133/6, Záběhlice, 106 00 Praha 10 http://www.facebook.com/people/Jakub-Javora/1158420875 http://www.linkedin.com/in/jakub-javora-94576336/ http://twitter.com/Banjavor http://www.instagram.com/jakub_javora/

karlisup commented 2 years ago

I'll close it for now as we soon plan to release 1.4.2 as a stable one and there have been no other reports regarding the alpha issue.