PhysicalAddons / physical-starlight-and-atmosphere

issue tracker
16 stars 2 forks source link

Keyframes added but not affecting anything #59

Open euge04 opened 2 years ago

euge04 commented 2 years ago

I can add keyframes to create a timelapse effect but the add on only respects the last setting I made.

General information

noidilin commented 2 years ago

I am experiencing the same issue. I can see the value changing when I jump around in different frames. However, the value stay unchanged when rendering animation, while manually render frame by frame works fine.

The spec of my computation:

karlisup commented 2 years ago

Thank you for reporting the issue! My guess is that the azimuth/elevation + sun object rotation synchronization function has something to do with this. We are working on a rework that should be more robust. As @adriansnetlis mentioned on our Discord channel regarding a similar topic - render farms:

This is due to the current method we're using for animations. We're working on an overhaul of it, however, which should allow us to improve renderfarm support or hopefully™ make it just work 100% of time. It's most likely going to take a few weeks to fully transition all our addon's animation handling to our new method (using drivers instead of a handler within addon's code) as well as testing it, so when it's done we'll update you to our renderfarm status.

Thank you for your patience!

karlisup commented 2 years ago

Had a chance past 2 days to create simple videos on new file with PSA enabled where I animate elevation and elevation+azimuth properties and this is what I got. Seems to work properly. https://youtu.be/WGQsjcW_9c8

Do you animate any other PSA parameter at the same time, or is it just sun object/azimuth, elevation? Can you think of something particular (extra steps) that I've to make in order to reproduce the issue? That would help a lot :).

micahganske commented 2 years ago

I just wanted to add that I'm having the same issue. Currently using Blender 3.1 on windows 11, rendering with cycles. The only property with keyframes is elevation. The sun updates properly in rendered viewport but remains at frame 0 position when rendering animation frames.

karlisup commented 2 years ago

Hi @micahganske, Is there any way that you could send a blendfile containing this animation (or recreate a new simple animation with the same behaviour)? That would help a lot having real case. I could look at it than tomorrow early morning (Riga time).

micahganske commented 2 years ago

Sure thing, @karlisup! I just emailed you a dropbox link to the blend file.

karlisup commented 2 years ago

Thank you again @micahganske for the demo file <3! Every frame azimuth change is so tiny that our optimization function which does not call a redraw if parameters have not been changed counts it as no changes to the elevation parameter. Will try and add a hot-fix version by the end of the day.

Thank you everyone for your patience 🙏.

noidilin commented 2 years ago

Hi @karlisup, I also just uploaded a scene and emailed you the google drive link of it. I hope you find that information helpful.

karlisup commented 2 years ago

Every frame azimuth change is so tiny that our optimization function which does not call a redraw if parameters have not been changed counts it as no changes to the elevation parameter.

Seems like I was wrong on this one. In the viewport parameters update, but in the animation they don't - still seems very fishy. A quick fix that got animation working was unlocking the interface when rendering. Will keep investigating this. Sorry for false happy news.

karlisup commented 2 years ago

Regretfully for now as a workaround I propose unlocking interface as it seems that without this feature enabled sunlight gets rendered. Meanwhile, with @adriansnetlis we had a meeting discussing our permanent future proposal for fixing all animation-related issues. Currently, we are addressing sun object and azimuth/elevation parameter synchronization issue which is just annoying and maybe impossible to tackle without affecting UX.

image

Could you please report if not locking the interface fixes issue for you?

noidilin commented 2 years ago

Thanks for the prompt reply. I just tested the original scene and also a brand-new test scene without enabling "Lock Interface". I have a bit of good news that the issue is fixed, and all animation render just fined. I uploaded the render to the same google drive. You can view the images with the same link in the email.

karlisup commented 2 years ago

Thank you for the confirmation 👌 . I added a has a workaround tag to the issue.

micahganske commented 2 years ago

Thank you @karlisup! This worked perfectly. Only issue I had was that initially I was unable to uncheck "Lock Interface". Couldn't even unlock it through python, but then discovered, thanks to the fine sleuthing work at this post: https://developer.blender.org/T85244 , that if you have lodify installed, it forces the lock to stay on. Disabling it fixes the issue on restart though! Thanks again and as I always I will look forward to future updates since it's the best addon ever!