PhysicalAddons / physical-starlight-and-atmosphere

issue tracker
16 stars 2 forks source link

Renaming sun object (in outliner) creates duplicate; undoing causes segfault #94

Open Diti opened 8 months ago

Diti commented 8 months ago

The PSA add-on crashes (__init__.py, line 147 in sun_handler) during undoing (Ctrl–Z) if PSA’s sun object has been renamed in the Outliner’s View Layer (where the list of collections and objects is displayed in Blender’s GUI). Undo is a natural operation because the renaming creates a duplicate sun (so the add-on doesn’t like the sun being renamed).

General information

Consistent segfaults

  1. Factory startup.
  2. Enable add-on for the scene.
  3. Double-click the Starlight Sun item in the outliner, and rename it (to “global.sun” in most of my scenes).
  4. Undo with Ctrl–Z.

Inconsistent segfaults

I have gotten other related segfaults that aren’t related to the outliner, but I haven’t been able to fully replicate yet.

Either way, crashes always happen if the renaming happened in the outliner.

Diti commented 7 months ago

This requires the crash label, but I can’t add it myself.