search

PhysicsOfMobility / ridepy

Simulates a dispatching algorithm serving exogenous transportation requests with a fleet of vehicles. Does not simulate the universe, unlike MATSim. Batteries are included.
https://ridepy.org
MIT License
7 stars 0 forks source link

Fundamentally refactor the analytics tests #204

Open fxjung opened 2 years ago

fxjung commented 2 years ago

Most of the analytics suite testing is done by a single, almost 1000 line test that is completely unwieldy and impossible to maintain in the long term. This needs to be split up into the essential parts that are of utmost importance, and other parts, that are not so much. In general, the more project-specific analytics code should move to ridepy-extras, along with the corresponding test code.

fxjung commented 2 years ago

Not to mention that part of the get_vehicle_quantities functionality is actually broken (or was, I don't remember), which was "checked" by the test. This proves that the current testing scheme does not work.