PhysioLabXR / PhysioLabXR-Community

GNU General Public License v3.0
31 stars 13 forks source link

installation downgrades numpy #118

Closed lucask07 closed 1 year ago

lucask07 commented 1 year ago

Question to investigate: Must physiolabxr specify a scipy version?

On a MAC my pip install proceeds as:

Collecting numpy>=1.26.0 (from physiolabxr)
  Downloading numpy-1.26.1-cp39-cp39-macosx_10_9_x86_64.whl.metadata (61 kB)

but then...

Collecting numpy (from physiolabxr)
  Downloading numpy-1.21.6-cp39-cp39-macosx_10_9_x86_64.whl (17.0 MB)

Which I believe is from the installation of scipy. At the end of the installation there's a note:

Uninstalling numpy-1.23.4:

Successfully installed EasyProcess-1.1 Pillow-10.1.0 PyOpenGL-3.1.7 PyOpenGL-accelerate-3.1.7 PyQt6-6.5.3 PyQt6-Qt6-6.5.3 PyQt6-sip-13.6.0 brainflow-5.10.1 entrypoint2-1.1 mss-9.0.1 nptyping-1.4.4 numpy-1.21.6 opencv-python-4.8.1.78 physiolabxr-1.0.0b0 pylsl-1.16.2 pyqtgraph-0.13.3 pyscreenshot-3.1 pyscreeze-0.1.29 pytest-qt-4.2.0 pyxdf-1.16.4 soundfile-0.12.1 typish-1.9.3
HaowenWeiJohn commented 1 year ago

Hello @lucask07,

Thank you for bringing this issue to our attention. It is important to maintain compatibility and accuracy in our package requirements. I would like to inform you that we have made the necessary adjustments to our package requirements to address the compatibility issue you highlighted.

Previously, our requirements included numpy >= 1.26.0 and scipy ~= 1.9.1. However, we noticed that scipy ~= 1.9.1 necessitates numpy < 1.25.0, >= 1.18.5, which is incompatible with the requirement for numpy >= 1.26.0. To resolve this conflict, we have revised our requirements to the following:

These adjustments should ensure compatibility while allowing for the necessary dependencies. Thank you for your attention to detail, and please let us know if you have any further concerns or suggestions.

Best regards, Haowen 'John' Wei & PhysioLabXR Team

ApocalyVec commented 1 year ago

See #119