search

Pi-Star-Lab / RESCO

Reinforcement Learning Benchmarks for Traffic Signal Control (RESCO)
116 stars 36 forks source link

Simplifies phase identification w/ traci #10

Closed mschrader15 closed 1 year ago

mschrader15 commented 1 year ago

Thanks for creating this library @jault ! We are excited to benchmark our signal control algos.

I created this PR to simplify some of the initialization code. Would you be open to more of these / refactoring and code formatting PR's?

jault commented 1 year ago

Thanks for the contribution, I'll give it a test and merge it soon (have some deadlines to meet the next couple days). Improving the codebase would be good.. I had always intended to come back to improve it, absolutely open to help.

mschrader15 commented 1 year ago

Great, I'll keep the PR's coming then!