search

Pi4J / pi4j-v1

DEPRECATED Java I/O library for Raspberry Pi (GPIO, I2C, SPI, UART)
http://www.pi4j.com
Apache License 2.0
1.31k stars 447 forks source link

Develop/1.4 #485

Closed cvdenzen closed 4 years ago

cvdenzen commented 4 years ago

Because I ran into a problem, I tried to compile pi4j. When I saw the compile warnings I fixed them. Unfortunately my IDE (IntellIJ) made some edits on its own: it changed the copyright notice and it added at least one @Deprecated annotation. Some of these edits are in the same commit as edits that I made. I hope the code is now cleaner than before.

eitch commented 4 years ago

Hi @cvdenzen

I don't think you should merge directly into master, you probably meant to pull onto develop/1.4?

cvdenzen commented 4 years ago

Hello Robert,

Yes indeed, I meant to make a merge request into develop/1.4. I have changed the base branch to develop/1.4.

Thank you, Carl van Denzen

Op 15 apr. 2020 om 08:35 heeft Robert von Burg notifications@github.com het volgende geschreven:

 Hi @cvdenzen

I don't think you should merge directly into master, you probably meant to pull onto develop/1.4?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

FDelporte commented 4 years ago

Bedankt Carl voor je bijdrage - now switching back to English for the rest of the team ;-) - will not merge this PR as it contains mainly cleanups which will happen anyway in the further process of V1.4 release.